← CVE Intelligence

CVE-2023-52925

netfilter: nf_tables: don't fail inserts if duplicate has expired PUBLISHED

Description (CNA)

In the Linux kernel, the following vulnerability has been resolved: netfilter: nf_tables: don't fail inserts if duplicate has expired nftables selftests fail: run-tests.sh testcases/sets/0044interval_overlap_0 Expected: 0-2 . 0-3, got: W: [FAILED] ./testcases/sets/0044interval_overlap_0: got 1 Insertion must ignore duplicate but expired entries. Moreover, there is a strange asymmetry in nft_pipapo_activate: It refetches the current element, whereas the other ->activate callbacks (bitmap, hash, rhash, rbtree) use elem->priv. Same for .remove: other set implementations take elem->priv, nft_pipapo_remove fetches elem->priv, then does a relookup, remove this. I suspect this was the reason for the change that prompted the removal of the expired check in pipapo_get() in the first place, but skipping exired elements there makes no sense to me, this helper is used for normal get requests, insertions (duplicate check) and deactivate callback. In first two cases expired elements must be skipped. For ->deactivate(), this gets called for DELSETELEM, so it seems to me that expired elements should be skipped as well, i.e. delete request should fail with -ENOENT error.

Affected (CNA)

Vendor / productVersions
Linux / Linuxaffected b15ea4017af82011dd55225ce77cce3d4dfc169c before 891ca5dfe3b718b441fc786014a7ba8f517da188; affected 7c7e658a36f8b1522bd3586d8137e5f93a25ddc5 before af78b0489e8898a8c9449ffc0fdd2e181916f0d4; affected 59dab3bf0b8fc08eb802721c0532f13dd89209b8 before 59ee68c437c562170265194a99698c805a686bb3; affected bd156ce9553dcaf2d6ee2c825d1a5a1718e86524 before 156369a702c33ad5434a19c3a689bfb836d4e0b8; affected 24138933b97b055d486e8064b4a1721702442a9b before 7845914f45f066497ac75b30c50dbc735e84e884; affected 94313a196b44184b5b52c1876da6a537701b425a; affected 1da4874d05da1526b11b82fc7f3c7ac38749ddf8; affected 4.19.316 before 4.20; affected 5.4.262 before 5.5
Linux / Linuxaffected 6.4.11 before 6.4.12

CWE

No CWE identifiers supplied.

References

ADP enrichment

CISA-ADP

No English description supplied.

No references supplied.