← CVE Intelligence

CVE-2024-26935

scsi: core: Fix unremoved procfs host directory regression PUBLISHED

Description (CNA)

In the Linux kernel, the following vulnerability has been resolved: scsi: core: Fix unremoved procfs host directory regression Commit fc663711b944 ("scsi: core: Remove the /proc/scsi/${proc_name} directory earlier") fixed a bug related to modules loading/unloading, by adding a call to scsi_proc_hostdir_rm() on scsi_remove_host(). But that led to a potential duplicate call to the hostdir_rm() routine, since it's also called from scsi_host_dev_release(). That triggered a regression report, which was then fixed by commit be03df3d4bfe ("scsi: core: Fix a procfs host directory removal regression"). The fix just dropped the hostdir_rm() call from dev_release(). But it happens that this proc directory is created on scsi_host_alloc(), and that function "pairs" with scsi_host_dev_release(), while scsi_remove_host() pairs with scsi_add_host(). In other words, it seems the reason for removing the proc directory on dev_release() was meant to cover cases in which a SCSI host structure was allocated, but the call to scsi_add_host() didn't happen. And that pattern happens to exist in some error paths, for example. Syzkaller causes that by using USB raw gadget device, error'ing on usb-storage driver, at usb_stor_probe2(). By checking that path, we can see that the BadDevice label leads to a scsi_host_put() after a SCSI host allocation, but there's no call to scsi_add_host() in such path. That leads to messages like this in dmesg (and a leak of the SCSI host proc structure): usb-storage 4-1:87.51: USB Mass Storage device detected proc_dir_entry 'scsi/usb-storage' already registered WARNING: CPU: 1 PID: 3519 at fs/proc/generic.c:377 proc_register+0x347/0x4e0 fs/proc/generic.c:376 The proper fix seems to still call scsi_proc_hostdir_rm() on dev_release(), but guard that with the state check for SHOST_CREATED; there is even a comment in scsi_host_dev_release() detailing that: such conditional is meant for cases where the SCSI host was allocated but there was no calls to {add,remove}_host(), like the usb-storage case. This is what we propose here and with that, the error path of usb-storage does not trigger the warning anymore.

Affected (CNA)

Vendor / productVersions
Linux / Linuxaffected 88c3d3bb6469cea929ac68fd326bdcbefcdfdd83 before 0053f15d50d50c9312d8ab9c11e2e405812dfcac; affected 68c665bb185037e7eb66fb792c61da9d7151e99c before 5c2386ba80e779a92ec3bb64ccadbedd88f779b1; affected 2a764d55e938743efa7c2cba7305633bcf227f09 before cea234bb214b17d004dfdccce4491e6ff57c96ee; affected 7e0ae8667fcdd99d1756922e1140cac75f5fa279 before 3678cf67ff7136db1dd3bf63c361650db5d92889; affected be03df3d4bfe7e8866d4aa43d62e648ffe884f5f before d4c34782b6d7b1e68d18d9549451b19433bd4c6c; affected be03df3d4bfe7e8866d4aa43d62e648ffe884f5f before e293c773c13b830cdc251f155df2254981abc320; affected be03df3d4bfe7e8866d4aa43d62e648ffe884f5f before f4ff08fab66eb5c0b97e1a24edac052fb40bf5d7; affected be03df3d4bfe7e8866d4aa43d62e648ffe884f5f before f23a4d6e07570826fe95023ca1aa96a011fa9f84; affected 73f030d4ef6d1ad17f824a0a2eb637ef7a9c7d51; affected 5.4.238 before 5.4.274; affected 5.10.176 before 5.10.215; affected 5.15.104 before 5.15.154; affected 6.1.21 before 6.1.84; affected 6.2.8 before 6.3
Linux / Linuxaffected 6.3; unaffected 0 before 6.3; unaffected 5.4.274 through 5.4.*; unaffected 5.10.215 through 5.10.*; unaffected 5.15.154 through 5.15.*; unaffected 6.1.84 through 6.1.*; unaffected 6.6.24 through 6.6.*; unaffected 6.7.12 through 6.7.*; unaffected 6.8.3 through 6.8.*; unaffected 6.9 through *

CWE

No CWE identifiers supplied.

References

ADP enrichment

CISA-ADP

No English description supplied.

No references supplied.

CVE

No English description supplied.

siemens-SADP

No English description supplied.