Description (CNA)
In the Linux kernel, the following vulnerability has been resolved: nfc: nci: fix circular locking dependency in nci_close_device nci_close_device() flushes rx_wq and tx_wq while holding req_lock. This causes a circular locking dependency because nci_rx_work() running on rx_wq can end up taking req_lock too: nci_rx_work -> nci_rx_data_packet -> nci_data_exchange_complete -> __sk_destruct -> rawsock_destruct -> nfc_deactivate_target -> nci_deactivate_target -> nci_request -> mutex_lock(&ndev->req_lock) Move the flush of rx_wq after req_lock has been released. This should safe (I think) because NCI_UP has already been cleared and the transport is closed, so the work will see it and return -ENETDOWN. NIPA has been hitting this running the nci selftest with a debug kernel on roughly 4% of the runs.
Affected (CNA)
| Vendor / product | Versions |
|---|---|
| Linux / Linux | affected 6a2968aaf50c7a22fced77a5e24aa636281efca8 before 7ed00a3edc8597fe2333f524401e2889aa1b5edf; affected 6a2968aaf50c7a22fced77a5e24aa636281efca8 before 5eef9ebec7f5738f12cadede3545c05b34bf5ac3; affected 6a2968aaf50c7a22fced77a5e24aa636281efca8 before ca54e904a071aa65ef3ad46ba42d51aaac6b73b4; affected 6a2968aaf50c7a22fced77a5e24aa636281efca8 before eb435d150ca74b4d40f77f1a2266f3636ed64a79; affected 6a2968aaf50c7a22fced77a5e24aa636281efca8 before 1edc12d2bbcb7a8d0f1088e6fccb9d8c01bb1289; affected 6a2968aaf50c7a22fced77a5e24aa636281efca8 before d89b74bf08f067b55c03d7f999ba0a0e73177eb3; affected 6a2968aaf50c7a22fced77a5e24aa636281efca8 before 09143c0e8f3b03517e6233aad42f45c794d8df8e; affected 6a2968aaf50c7a22fced77a5e24aa636281efca8 before 4527025d440ce84bf56e75ce1df2e84cb8178616 |
| Linux / Linux | affected 3.2; unaffected 0 before 3.2; unaffected 5.10.253 through 5.10.*; unaffected 5.15.203 through 5.15.*; unaffected 6.1.168 through 6.1.*; unaffected 6.6.131 through 6.6.*; unaffected 6.12.80 through 6.12.*; unaffected 6.18.21 through 6.18.*; unaffected 6.19.11 through 6.19.*; unaffected 7.0 through * |
CWE
No CWE identifiers supplied.
References
- https://git.kernel.org/stable/c/7ed00a3edc8597fe2333f524401e2889aa1b5edf
- https://git.kernel.org/stable/c/5eef9ebec7f5738f12cadede3545c05b34bf5ac3
- https://git.kernel.org/stable/c/ca54e904a071aa65ef3ad46ba42d51aaac6b73b4
- https://git.kernel.org/stable/c/eb435d150ca74b4d40f77f1a2266f3636ed64a79
- https://git.kernel.org/stable/c/1edc12d2bbcb7a8d0f1088e6fccb9d8c01bb1289
- https://git.kernel.org/stable/c/d89b74bf08f067b55c03d7f999ba0a0e73177eb3
- https://git.kernel.org/stable/c/09143c0e8f3b03517e6233aad42f45c794d8df8e
- https://git.kernel.org/stable/c/4527025d440ce84bf56e75ce1df2e84cb8178616