Description (CNA)
In the Linux kernel, the following vulnerability has been resolved: media: vivid: check for vb2_is_busy() when toggling caps The vivid_update_format_cap/out() functions must only be called if the capture/output queue are not busy. But for the controls that select the CROP/COMPOSE/SCALE capability that is not checked. Only when streaming starts will they be set to 'grabbed' and it is impossible to change the control, but between REQBUFS and STREAMON you are still allowed to set these controls. Since vivid_update_format_cap/out will change the format, this can cause unexpected results. Besides adding these checks, also add a WARN_ON in vivid_update_format_cap/out() if the queue is busy. I'm 90% certain that this is the cause of this syzbot bug: https://syzkaller.appspot.com/bug?extid=dac8f5eaa46837e97b89 But since we never have reproducers, it is hard to be certain. In any case, these checks are needed regardless.
Affected (CNA)
| Vendor / product | Versions |
|---|---|
| Linux / Linux | affected 73c3f48230cda01402ae189b05d56f1f7e0d53c9 before 0a820f03727b509b887f3216a574062948761f34; affected 73c3f48230cda01402ae189b05d56f1f7e0d53c9 before bbc96bc75de0fcd9bb6ac48798b206e3b09ec865; affected 73c3f48230cda01402ae189b05d56f1f7e0d53c9 before 6a5bc8aea111ccbca71ef2b9c868d5c81f2e89de; affected 73c3f48230cda01402ae189b05d56f1f7e0d53c9 before a9cd0e8fb0b21faaa71199d9d3feb305c18ff576; affected 73c3f48230cda01402ae189b05d56f1f7e0d53c9 before abaec6747304581f8d4a9936352fa10e13325f07; affected 73c3f48230cda01402ae189b05d56f1f7e0d53c9 before 492c97cb50feaa60ccd7792d3d6b904ed8ec61bf; affected 73c3f48230cda01402ae189b05d56f1f7e0d53c9 before daf2d92669b4a659d805d88d811161c70cd325ee; affected 73c3f48230cda01402ae189b05d56f1f7e0d53c9 before c2d1a2130c93f6d758af58590b86b2254c7a1dec |
| Linux / Linux | affected 3.18; unaffected 0 before 3.18; unaffected 5.10.265 through 5.10.*; unaffected 5.15.216 through 5.15.*; unaffected 6.1.183 through 6.1.*; unaffected 6.6.148 through 6.6.*; unaffected 6.12.101 through 6.12.*; unaffected 6.18.42 through 6.18.*; unaffected 7.1.6 through 7.1.*; unaffected 7.2 through * |
CWE
No CWE identifiers supplied.
References
- https://git.kernel.org/stable/c/0a820f03727b509b887f3216a574062948761f34
- https://git.kernel.org/stable/c/bbc96bc75de0fcd9bb6ac48798b206e3b09ec865
- https://git.kernel.org/stable/c/6a5bc8aea111ccbca71ef2b9c868d5c81f2e89de
- https://git.kernel.org/stable/c/a9cd0e8fb0b21faaa71199d9d3feb305c18ff576
- https://git.kernel.org/stable/c/abaec6747304581f8d4a9936352fa10e13325f07
- https://git.kernel.org/stable/c/492c97cb50feaa60ccd7792d3d6b904ed8ec61bf
- https://git.kernel.org/stable/c/daf2d92669b4a659d805d88d811161c70cd325ee
- https://git.kernel.org/stable/c/c2d1a2130c93f6d758af58590b86b2254c7a1dec