Description (CNA)
In the Linux kernel, the following vulnerability has been resolved: media: msi2500: Return queued buffers on start_streaming() failure The vb2 framework hands buffers to the driver via buf_queue() before calling start_streaming(). If start_streaming() returns an error without first returning those buffers via vb2_buffer_done(), vb2_start_streaming() fires WARN_ON(owned_by_drv_count) and the queued buffers leak. msi2500_start_streaming() had five error paths that all hit this trap and were further tangled by ret-overwriting between calls: - -ENODEV when the USB device was already disconnected - -ERESTARTSYS when mutex_lock_interruptible() was interrupted - msi2500_set_usb_adc() failure: ret was silently overwritten by the next call (msi2500_isoc_init), so the error was lost entirely - msi2500_isoc_init() failure: cleanup_queued_bufs was called, but the function then fell through to msi2500_ctrl_msg() and again masked the original error by overwriting ret - msi2500_ctrl_msg(CMD_START_STREAMING) failure: no cleanup at all, leaving isoc URBs submitted with no way for the driver to consume them Consolidate the error paths into a small goto chain. Every failure now stops the function, drains the queued-buffer list, and returns the real error code. The ctrl_msg failure path also rolls back the preceding msi2500_isoc_init() via msi2500_isoc_cleanup() before unlocking and draining. The cleanup helper takes a vb2_buffer_state argument so that the start_streaming error paths can pass VB2_BUF_STATE_QUEUED (as expected by userspace on start_streaming failure) while stop_streaming keeps its existing VB2_BUF_STATE_ERROR semantics. This mirrors the uvcvideo fix in commit 4cf3b6fd54eb ("media: uvcvideo: Return queued buffers on start_streaming() failure").
Affected (CNA)
| Vendor / product | Versions |
|---|---|
| Linux / Linux | affected 977e444f59ad16eedf66acae4f357011c74da291 before c74b680704baecea4620c0774de473069e0bc4e8; affected 977e444f59ad16eedf66acae4f357011c74da291 before 2d10eedb786a13f91d76e11320fabb0bf712519f; affected 977e444f59ad16eedf66acae4f357011c74da291 before 2de14ddb4fea04ca616403a6ba81c5e8099e9b9e; affected 977e444f59ad16eedf66acae4f357011c74da291 before 1d58229b330b7f67fbfa07e0f2a8a51fbeafaa9a; affected 977e444f59ad16eedf66acae4f357011c74da291 before bab9d5a67d4db96ae8c187b92b37979911302a10; affected 977e444f59ad16eedf66acae4f357011c74da291 before 264b5380c4f8aa92dbc2983ecd2b627f1d5e0061; affected 977e444f59ad16eedf66acae4f357011c74da291 before 3673cb0a5711e910074d69201da9e1535c03f97a; affected 977e444f59ad16eedf66acae4f357011c74da291 before 7201c17786a498497bca57752883b90914d405ac |
| Linux / Linux | affected 3.12; unaffected 0 before 3.12; unaffected 5.10.265 through 5.10.*; unaffected 5.15.216 through 5.15.*; unaffected 6.1.183 through 6.1.*; unaffected 6.6.148 through 6.6.*; unaffected 6.12.101 through 6.12.*; unaffected 6.18.42 through 6.18.*; unaffected 7.1.6 through 7.1.*; unaffected 7.2 through * |
CWE
No CWE identifiers supplied.
References
- https://git.kernel.org/stable/c/c74b680704baecea4620c0774de473069e0bc4e8
- https://git.kernel.org/stable/c/2d10eedb786a13f91d76e11320fabb0bf712519f
- https://git.kernel.org/stable/c/2de14ddb4fea04ca616403a6ba81c5e8099e9b9e
- https://git.kernel.org/stable/c/1d58229b330b7f67fbfa07e0f2a8a51fbeafaa9a
- https://git.kernel.org/stable/c/bab9d5a67d4db96ae8c187b92b37979911302a10
- https://git.kernel.org/stable/c/264b5380c4f8aa92dbc2983ecd2b627f1d5e0061
- https://git.kernel.org/stable/c/3673cb0a5711e910074d69201da9e1535c03f97a
- https://git.kernel.org/stable/c/7201c17786a498497bca57752883b90914d405ac