Description (CNA)
In the Linux kernel, the following vulnerability has been resolved: nfc: nci: fix double completion race in nci_data_exchange_complete nci_close_device() and nci_rx_work can both call nci_data_exchange_complete() concurrently. After commit 4527025d440ce8 ("nfc: nci: fix circular locking dependency in nci_close_device") moved flush_workqueue(ndev->rx_wq) after mutex_unlock(&ndev->req_lock), rx_work is no longer serialized with the explicit completion call in the close path. Both callers read the non-NULL callback pointer and invoke rawsock_data_exchange_complete(), which calls sock_put() -- but only one sock_hold() was taken, so the second sock_put() underflows the refcount and frees the socket while it is still in use. Replace the bare clear_bit(NCI_DATA_EXCHANGE) with test_and_clear_bit() so that only the first caller proceeds to invoke the callback.
Affected (CNA)
| Vendor / product | Versions |
|---|---|
| Linux / Linux | affected 7ed00a3edc8597fe2333f524401e2889aa1b5edf before 3f075832734005310740d148d1cf1c1e792ebdca; affected 5eef9ebec7f5738f12cadede3545c05b34bf5ac3 before 588ccd19a6e69eca72d54608c3ab3b45709b2305; affected ca54e904a071aa65ef3ad46ba42d51aaac6b73b4 before cf646a9f5554bc07d6ccb59c327812b3a0c6a368; affected eb435d150ca74b4d40f77f1a2266f3636ed64a79 before 9030a1bbe2c6b1e3e54cef462d159b5248f09fd2; affected 1edc12d2bbcb7a8d0f1088e6fccb9d8c01bb1289 before bfdf412208fea7fc0d5b32d68a35b25261917393; affected d89b74bf08f067b55c03d7f999ba0a0e73177eb3 before ba4c776af3dc21ed04e315e6545e99703bb1b53a; affected 4527025d440ce84bf56e75ce1df2e84cb8178616 before ee08414d78b851e3d1856d6e4d631939b01a1bbe; affected 4527025d440ce84bf56e75ce1df2e84cb8178616 before 8265a626cc14a48e46e6dc8c47667e72b4232ac2; affected 09143c0e8f3b03517e6233aad42f45c794d8df8e; affected 5.10.253 before 5.10.270; affected 5.15.203 before 5.15.221; affected 6.1.168 before 6.1.188; affected 6.6.131 before 6.6.157; affected 6.12.80 before 6.12.110; affected 6.18.21 before 6.18.52; affected 6.19.11 before 6.20 |
| Linux / Linux | affected 7.0; unaffected 0 before 7.0; unaffected 5.10.270 through 5.10.*; unaffected 5.15.221 through 5.15.*; unaffected 6.1.188 through 6.1.*; unaffected 6.6.157 through 6.6.*; unaffected 6.12.110 through 6.12.*; unaffected 6.18.52 through 6.18.*; unaffected 7.2.6 through 7.2.*; unaffected 7.3 through * |
CWE
No CWE identifiers supplied.
References
- https://git.kernel.org/stable/c/3f075832734005310740d148d1cf1c1e792ebdca
- https://git.kernel.org/stable/c/588ccd19a6e69eca72d54608c3ab3b45709b2305
- https://git.kernel.org/stable/c/cf646a9f5554bc07d6ccb59c327812b3a0c6a368
- https://git.kernel.org/stable/c/9030a1bbe2c6b1e3e54cef462d159b5248f09fd2
- https://git.kernel.org/stable/c/bfdf412208fea7fc0d5b32d68a35b25261917393
- https://git.kernel.org/stable/c/ba4c776af3dc21ed04e315e6545e99703bb1b53a
- https://git.kernel.org/stable/c/ee08414d78b851e3d1856d6e4d631939b01a1bbe
- https://git.kernel.org/stable/c/8265a626cc14a48e46e6dc8c47667e72b4232ac2