Description (CNA)
In the Linux kernel, the following vulnerability has been resolved: scsi: core: Do not block on tag allocation in scsi_eh_lock_door() scsi_eh_lock_door() is called from scsi_restart_operations() while the host is still in the SHOST_RECOVERY state, i.e. before the host is switched back to SHOST_RUNNING and scsi_run_host_queues() restarts the queues. It allocates a request via scsi_alloc_request() with no flags, so blk_mq_get_tag() may block waiting for a free sched tag when all tags are already in use. Those tags can be held by commands that were just requeued by scsi_eh_flush_done_q() during error handling. Such commands cannot be dispatched until the host leaves SHOST_RECOVERY and scsi_run_host_queues() is called - which only happens *after* scsi_eh_lock_door() returns. This forms a circular dependency: - scsi_eh_lock_door(), running in the SCSI error handler thread, waits for a sched tag held by a requeued command; - the requeued command cannot complete and release its sched tag until the error handler thread leaves scsi_restart_operations() and restart the queues. For devices with a single driver tag (e.g. USB storage) it is a guaranteed deadlock and I/O that can never be submitted. This problem has also been reproduced in our environment. Locking the door is a best-effort operation, and scsi_eh_lock_door() already returns silently when the request allocation fails. Pass BLK_MQ_REQ_NOWAIT to scsi_alloc_request() so the allocation fails instead of blocking when no tag is available. This breaks the circular dependency and allows the error handler to finish restarting the queues, after which the pending commands are dispatched normally.
Affected (CNA)
| Vendor / product | Versions |
|---|---|
| Linux / Linux | affected 6e68af666f5336254b5715dca591026b7324499a before 3bc7af4cefac1c583f0607f6183a67012436aad9; affected 6e68af666f5336254b5715dca591026b7324499a before 6b450c277c106c4e31411067f025d1aaa27c2a02; affected 6e68af666f5336254b5715dca591026b7324499a before 261c80a6b23e34ba98bcf3f75317e35ecf0a08f0; affected 6e68af666f5336254b5715dca591026b7324499a before dc9e1b6b9080dd6374cc9a38e4b53abca63c3b1b; affected 6e68af666f5336254b5715dca591026b7324499a before 732cb6bb37fd26863d5786522fb1997e7f5865b4 |
| Linux / Linux | affected 2.6.16; unaffected 0 before 2.6.16; unaffected 6.1.189 through 6.1.*; unaffected 6.6.158 through 6.6.*; unaffected 6.12.111 through 6.12.*; unaffected 6.18.53 through 6.18.*; unaffected 7.2 through * |
CWE
No CWE identifiers supplied.
References
- https://git.kernel.org/stable/c/3bc7af4cefac1c583f0607f6183a67012436aad9
- https://git.kernel.org/stable/c/6b450c277c106c4e31411067f025d1aaa27c2a02
- https://git.kernel.org/stable/c/261c80a6b23e34ba98bcf3f75317e35ecf0a08f0
- https://git.kernel.org/stable/c/dc9e1b6b9080dd6374cc9a38e4b53abca63c3b1b
- https://git.kernel.org/stable/c/732cb6bb37fd26863d5786522fb1997e7f5865b4