Description (CNA)
In the Linux kernel, the following vulnerability has been resolved: scsi: qla2xxx: Fix queue teardown NULL dma_free and bitmap locking qla25xx_free_req_que() and qla25xx_free_rsp_que() have two pre-existing bugs exposed on the error path of qla25xx_create_{req,rsp}_que(): 1. When dma_alloc_coherent() fails during queue creation, the error path calls the free function with req->ring / rsp->ring still NULL (from kzalloc). The unconditional dma_free_coherent() with a NULL cpu_addr is undefined behavior and can panic. 2. The free functions clear req_qid_map / rsp_qid_map under vport_lock, but the create functions protect the same bitmaps with mq_lock. This provides no mutual exclusion. Additionally, the create error path clears the bit and releases mq_lock before calling the free function, creating a window where another thread can allocate the same que_id and have its ha->req_q_map entry clobbered by the subsequent lockless NULL assignment in the free function. Fix by: - Guarding dma_free_coherent() with a NULL check on the ring pointer. - Using mq_lock (the lock held by all creators) in the free functions to atomically NULL the map entry and clear the bitmap bit. - Removing the now-redundant clear_bit blocks from the create error paths since the free functions handle it atomically.
Affected (CNA)
| Vendor / product | Versions |
|---|---|
| Linux / Linux | affected 73208dfd7ab19f379d73e8a0fbf30f92c203e5e8 before 2e6f60adf609c77e828f64e0cd371920bef91c12; affected 73208dfd7ab19f379d73e8a0fbf30f92c203e5e8 before 56e25d716833604fd5bff388e472f290bfe793aa; affected 73208dfd7ab19f379d73e8a0fbf30f92c203e5e8 before f35cb67f2092b49d7949065dd56895ed47238f22; affected 73208dfd7ab19f379d73e8a0fbf30f92c203e5e8 before 94fc0c5b45de2bf3a691619bcfd10b9a49fc647e; affected 73208dfd7ab19f379d73e8a0fbf30f92c203e5e8 before 34a40e0dff940ac5eba494a69b553ea571e24873 |
| Linux / Linux | affected 2.6.29; unaffected 0 before 2.6.29; unaffected 6.6.160 through 6.6.*; unaffected 6.12.112 through 6.12.*; unaffected 6.18.53 through 6.18.*; unaffected 7.2.7 through 7.2.*; unaffected 7.3 through * |
CWE
No CWE identifiers supplied.
References
- https://git.kernel.org/stable/c/2e6f60adf609c77e828f64e0cd371920bef91c12
- https://git.kernel.org/stable/c/56e25d716833604fd5bff388e472f290bfe793aa
- https://git.kernel.org/stable/c/f35cb67f2092b49d7949065dd56895ed47238f22
- https://git.kernel.org/stable/c/94fc0c5b45de2bf3a691619bcfd10b9a49fc647e
- https://git.kernel.org/stable/c/34a40e0dff940ac5eba494a69b553ea571e24873