Description (CNA)
In the Linux kernel, the following vulnerability has been resolved: ice: add missing xa_destroy for sched_node_ids Commit 16dfa49406bc ("ice: Introduce new parameters in ice_sched_node") added a sched_node_ids xarray to the port info structure, but never called xa_destroy on it. Since xarrays can allocate internal memory, this can result in a memory leak even if every element in the xarray has been removed. The xarray is currently embedded in the port_info structure. This appears to have been done because its use is within functions that take the port_info as a primary argument. However, this complicates managing the lifecycle of the field. The port_info structure is allocated in ice_init_hw() using devm, and it is not released until the devm cleanup when the driver is unloaded. The ice_init_hw() function is called in many places, including devlink reload, and possibly during DDP load after updating the Tx scheduler layout. Adding a call of xa_destroy to the ice_deinit_hw() causes Sashiko to raise multiple concerns due to potential ordering issues and possible ways that port_info could be a dangling reference. To handle this, move the sched_node_ids out of port_info and into the hw structure. All users of the array already have a pointer to hw anyways, and there is only one sched_node_ids per adapter. While here, remove the overly verbose comment explaining the nature of the sched_node_ids xarray. Add the missing xa_destroy to the cleanup path and to ice_deinit_hw(), ensuring that we properly release the xarray memory. This was caught by Sashiko during development of unrelated code.
Affected (CNA)
| Vendor / product | Versions |
|---|---|
| Linux / Linux | affected a388961be5ed8ee037ac68220e389bc4e9339a39 before 09a7cdf8fffb065a8aa30cfa604ff4a65cbf04c9; affected 16dfa49406bc5e1f4cbb115027cbd719d7e6c930 before c075a91fe5762d314e6e182d37d29cf874bd314a; affected 16dfa49406bc5e1f4cbb115027cbd719d7e6c930 before 44cdd6b7e036303f7fecf841cf23c05a4a4faf2d; affected 16dfa49406bc5e1f4cbb115027cbd719d7e6c930 before f5463bc124c0d6f922e272336584730c5c61c4f1; affected 16dfa49406bc5e1f4cbb115027cbd719d7e6c930 before d6f38fb12069fb1edf762962b5fcf3f42d643b47; affected 16dfa49406bc5e1f4cbb115027cbd719d7e6c930 before 53432c4c3e869076350aef319534431af8ba99c1; affected 6.1.95 before 6.1.189 |
| Linux / Linux | affected 6.2; unaffected 0 before 6.2; unaffected 6.1.189 through 6.1.*; unaffected 6.6.158 through 6.6.*; unaffected 6.12.111 through 6.12.*; unaffected 6.18.53 through 6.18.*; unaffected 7.2.7 through 7.2.*; unaffected 7.3 through * |
CWE
No CWE identifiers supplied.
References
- https://git.kernel.org/stable/c/09a7cdf8fffb065a8aa30cfa604ff4a65cbf04c9
- https://git.kernel.org/stable/c/c075a91fe5762d314e6e182d37d29cf874bd314a
- https://git.kernel.org/stable/c/44cdd6b7e036303f7fecf841cf23c05a4a4faf2d
- https://git.kernel.org/stable/c/f5463bc124c0d6f922e272336584730c5c61c4f1
- https://git.kernel.org/stable/c/d6f38fb12069fb1edf762962b5fcf3f42d643b47
- https://git.kernel.org/stable/c/53432c4c3e869076350aef319534431af8ba99c1